Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
May 4, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Looks good to me, important bugfix. WDYT @SaulLu?
SaulLu
approved these changes
May 4, 2022
Contributor
There was a problem hiding this comment.
Thank you very much for the proposed fix @deutschmn 🤗 !
To have more context, I have traced the history of the changes concerning DeBERTa's token_type_ids:
- In the first PR #5929 where Deverta was added the ids were 0 for the first sentence and 1 for the second;
- When the tokenizer fast was added in PR #11387 the choice was at that time to assign the 2 sentences to id 0 (see lines here and here);
- In a later bug fix in PR #10703, it seems that the ids were aligned to the fast version, i.e. only 0s (diff here - thanks @daniel-ziegler).
Looking at the history I also think it's a bug (nothing mentions that the ids should have been all assigned to 0) and the proposed fix seems the right one!
Contributor
Author
|
Great, thanks for looking into this! I also checked Microsoft's implementation and it looks like they use |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #15735. It changes the behavior of
DebertaTokenizerandDebertaTokenizerFastwhen passing pair inputs. Before, the token type IDs were all0. This PR changes this so that thetoken_type_ids for the tokens of the second sentence are1.It also adds a test case to test this behavior (
DebertaTokenizationTest.test_token_type_ids). Failed before, passes now.Before submitting
Pull Request section?
to it if that's the case.
DebertaTokenizeralways assigns token type ID 0 #15735documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@LysandreJik?